From f454c3811e6d4a52f5b55580004c16b6f3d9eb3d Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date: Sat, 25 Jun 2016 10:10:13 +1000 Subject: [PATCH] khugepaged: __collapse_huge_page_swapin(): drop unused 'pte' parameter 'pte' dereference is eliminated by compiler, since nobody uses the pteval until it's overwritten inside the loop. Value of 'pte' itself is overwritten by pte_offset_map() before first real use. Signed-off-by: Kirill A. Shutemov Cc: Ebru Akagunduz Signed-off-by: Andrew Morton --- mm/huge_memory.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 228c84da39ec53..3890c9f1707a2c 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2388,11 +2388,10 @@ static bool hugepage_vma_check(struct vm_area_struct *vma) static void __collapse_huge_page_swapin(struct mm_struct *mm, struct vm_area_struct *vma, - unsigned long address, pmd_t *pmd, - pte_t *pte) + unsigned long address, pmd_t *pmd) { unsigned long _address; - pte_t pteval = *pte; + pte_t *pte, pteval; int swapped_in = 0, ret = 0; pte = pte_offset_map(pmd, address); @@ -2486,7 +2485,7 @@ static void collapse_huge_page(struct mm_struct *mm, anon_vma_lock_write(vma->anon_vma); - __collapse_huge_page_swapin(mm, vma, address, pmd, pte); + __collapse_huge_page_swapin(mm, vma, address, pmd); pte = pte_offset_map(pmd, address); pte_ptl = pte_lockptr(mm, pmd);