Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRTs: allow anyone to trigger closing revenue share #5177

Open
mochet opened this issue Jul 9, 2024 · 1 comment
Open

CRTs: allow anyone to trigger closing revenue share #5177

mochet opened this issue Jul 9, 2024 · 1 comment

Comments

@mochet
Copy link

mochet commented Jul 9, 2024

Problem

People start a revenue share, it ends but they never place the closing TX which means it is impossible for the CRT to return to the market.

Solution

Allow for the runtime to let any account trigger the close revenue share TX--there doesn't seem to be any malicious action possible with this and the DAO could set up an account that does it automatically up to some certain scale.

@bedeho
Copy link
Member

bedeho commented Jul 9, 2024

Yeah, I just became aware of this today, I guess this was a problem with the way we chose to solve the problem we found, def. could have been done more practically, but allowing anyone to close is not needed, it can happen automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants