Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript config #40

Merged
merged 13 commits into from
Aug 12, 2024
Merged

Improve TypeScript config #40

merged 13 commits into from
Aug 12, 2024

Conversation

JstnMcBrd
Copy link
Owner

@JstnMcBrd JstnMcBrd commented Jun 21, 2024

Added

Changed

  • All dependencies to latest versions
  • vscode-eslint flat config support to be stable
  • process.exit to be directly imported like other dependencies
  • Command error message to use getSlashName() function
  • Optional parameter adding to abide by exactOptionalPropertyTypes
  • All references to Reflect.set to use Object.assign instead
  • Invite button disable to be false by default
  • Last updated date

Removed

  • noFallthroughCasesInSwitch from tsconfig (handled better by eslint)
  • Unused git ignores

@JstnMcBrd JstnMcBrd added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 21, 2024
@JstnMcBrd JstnMcBrd self-assigned this Jun 21, 2024
@JstnMcBrd
Copy link
Owner Author

JstnMcBrd commented Jun 24, 2024

TypeScript 5.5 throws errors when type-checking discord.js.

This appears to be an undocumented breaking change with the recent update - TypeScript 5.4 works fine. Turning on skipLibCheck is a valid workaround until discord.js fixes their types.

@JstnMcBrd JstnMcBrd marked this pull request as ready for review August 12, 2024 00:51
@JstnMcBrd JstnMcBrd merged commit 8ee4219 into main Aug 12, 2024
1 check passed
@JstnMcBrd JstnMcBrd deleted the mcb/ts branch August 12, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant