Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export scitype method. #131

Open
OkonSamuel opened this issue Jan 3, 2022 · 0 comments
Open

Don't export scitype method. #131

OkonSamuel opened this issue Jan 3, 2022 · 0 comments

Comments

@OkonSamuel
Copy link
Member

OkonSamuel commented Jan 3, 2022

Due to a recent change in ScientificTypesBase,jl from version 2.0 to 3.0, the ScientifictypesBase.scitype method is now a two argument method. Packages depending on MLJModelInterface.jl previously depended on the previous one argument version defined in version 2.0 series of ScientifictypesBase package.
A workaround is needed to avoid making MLJModelInterface breaking for its's users. This involves

  1. Defining a one argument scitype method in MLJModelInterface. Something in the lines of
scitype(X) = scitype(get_interface_mode(), X)
scitype(::LightInterface, X) = throw(ArgumentError("FullInterface is needed..."))

The corresponding FullInterface method would be implemented at MLJBase/src/Interface/data_utils.jl.

  1. exporting the scitype method at MLJModelInterface (Needed as users expect that the scitype method is exported. see MLJModelInterface no longer exporting scitype #129 )

But implementing the second step also leads to method import clashes with ScientificTypes.scitype at MLJBase. For now a hack at MLJBase/src/MLJBase.jl fixes this issue, but going forward the scitype method shouldn't be exported. Hence users that want to use the scitype method would have to qualify it with the package name e.g. MLJModelinterface.scitype(X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants