Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata_pkg should not set is_wrapper to false by default #209

Open
ablaom opened this issue Aug 1, 2024 · 0 comments
Open

metadata_pkg should not set is_wrapper to false by default #209

ablaom opened this issue Aug 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ablaom
Copy link
Member

ablaom commented Aug 1, 2024 •
edited
Loading

Indeed, this macro should not overload any trait that is not explicitly specified by the user, in my opinion. But in any case, is_wrapper is a model-specific trait, not necessarily pkg-generic.
@ablaom ablaom added the bug Something isn't working label Aug 1, 2024
@ablaom ablaom mentioned this issue Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom