Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frules/rrules should support receiving Thunks #408

Closed
mzgubic opened this issue May 11, 2021 · 0 comments · Fixed by #449
Closed

frules/rrules should support receiving Thunks #408

mzgubic opened this issue May 11, 2021 · 0 comments · Fixed by #449
Labels
design Requires some design before changes are made inplace for things relating to inplace accumulation needs-careful-thought A reminder that this thing is not obviouis and care must be taken when working on it
Milestone
v1

Comments

@mzgubic
Copy link
Member

mzgubic commented May 11, 2021

This came up in FluxML/Zygote.jl#966, which wants to support thunks inside Zygote, not just unthunking them as they come out of rrules.

Right now rrules are not explicitly required to support thunks as the input sensitivities. We could enforce this inside ChainRulesTestUtils, and if we do, we should probably decide for 1.0?
@mzgubic mzgubic added inplace for things relating to inplace accumulation design Requires some design before changes are made needs-careful-thought A reminder that this thing is not obviouis and care must be taken when working on it labels May 11, 2021
@mzgubic mzgubic added this to the v1 milestone May 11, 2021
@mzgubic mzgubic mentioned this issue May 11, 2021
Open
@oxinabox oxinabox mentioned this issue Jun 1, 2021
Closed
This was referenced Jun 11, 2021
Open
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Requires some design before changes are made inplace for things relating to inplace accumulation needs-careful-thought A reminder that this thing is not obviouis and care must be taken when working on it
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Test accepting thunks JuliaDiff/ChainRules.jl
1 participant
@mzgubic