Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move meta testing utilities into a new MetaTesting.jl package #62

Closed
oxinabox opened this issue Oct 7, 2020 · 7 comments · Fixed by #284
Closed

Move meta testing utilities into a new MetaTesting.jl package #62

oxinabox opened this issue Oct 7, 2020 · 7 comments · Fixed by #284

Comments

@oxinabox
Copy link
Member

oxinabox commented Oct 7, 2020

A follow-up to #60
we could make a new package in JuliaTesting called MetaTesting.jl to hold things like the function that captures all failures.

@sethaxen
Copy link
Member

I recently needed these meta testers for another package, so I'd like to take the initiative to put this package together and register it.

@sethaxen
Copy link
Member

Package created here: https://github.com/sethaxen/MetaTesting.jl. Will hold off on registering for a few days in case there are requested changes.

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented May 18, 2023

oh cool, I also recently wanted this! I used it for https://github.com/JuliaTesting/ReTestItems.jl/blob/main/test/_integration_test_tools.jl
think i might have needed to make some tweaks, but yeah if this was its own package that sounds good to me

@sethaxen
Copy link
Member

think i might have needed to make some tweaks, but yeah if this was it's own package that sounds good to me

Nice! Seems you replaced errors (checks that the tester errors) with errors (returns the number of errors thrown during testing), which makes sense. I proposed in JuliaTesting/MetaTesting.jl#1 that errors and fails are not very good names, and it might be better to add macros @test_fails expr and @test_errors expr to make it clearer and also simplify the syntax. Your functions also seem useful to add.

@nickrobinson251
Copy link
Contributor

yeah, sounds good -- thanks for making the package! -- i'll go open some feature requests there 😁

@oxinabox
Copy link
Member Author

@sethaxen will you open the PR here to switch us over to using the MetaTesting.jl package?

@sethaxen
Copy link
Member

@sethaxen will you open the PR here to switch us over to using the MetaTesting.jl package?

Absolutely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants