rrule_test requires returned composite objects to be collectable

[Kolaru]

rrule_test use collect to get the field of composite objects, but it is not always possible, as for e.g. qr

F = qr(randn(5, 5))
Q, R = F  # Valid since F is iterable
collect(F)  # Errors since length is not defined on LinearAlgebra.QRCompactWY

Using [y...] instead of collect(y) should do the trick.

[oxinabox]

Which collect in particular is a problem?
Several of them should go away once we do #57

[Kolaru]

The second one here:

ChainRulesTestUtils.jl/src/testers.jl

Line 235 in 6f5cd3f

@test y_ad == y || isapprox(collect(y_ad), collect(y); rtol=rtol, atol=atol)

[oxinabox]

Yep that one will go away when we do #57 right

[nickrobinson251]

Did removing the collect calls (in #57) resolve this?

[oxinabox]

yes