Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Reverse Dependency Integration Test #85

Closed
oxinabox opened this issue Dec 15, 2020 · 1 comment · Fixed by #105
Closed

More Reverse Dependency Integration Test #85

oxinabox opened this issue Dec 15, 2020 · 1 comment · Fixed by #105
Labels
enhancement New feature or request
Milestone

Comments

@oxinabox
Copy link
Member

oxinabox commented Dec 15, 2020

We should have reverse dependency intregration tests on thigns that have a dependency (including test time)
on ChainRulesTestUtils.

Adding more of these should not be hard because it should basically be copying what we already have.
Perhaps smartly using a matrix

Us not chatching JuliaArrays/BlockDiagonals.jl#49 until nightly ran, when we could have avoided it in #57 is not great.
(Though can't deny that Nightly build is given value there)

@oxinabox
Copy link
Member Author

This also had us miss JuliaMath/SpecialFunctions.jl#288 (comment)

@oxinabox oxinabox changed the title Reverse Dependency Integration Test More Reverse Dependency Integration Test Dec 21, 2020
@nickrobinson251 nickrobinson251 added this to the v1 milestone Dec 22, 2020
@nickrobinson251 nickrobinson251 added the enhancement New feature or request label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants