Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFE/DTC should be moved to ApproximateGPs.jl #318

Open
theogf opened this issue Apr 19, 2022 · 4 comments
Open

VFE/DTC should be moved to ApproximateGPs.jl #318

theogf opened this issue Apr 19, 2022 · 4 comments

Comments

@theogf
Copy link
Member

theogf commented Apr 19, 2022

No description provided.

@willtebbutt
Copy link
Member

willtebbutt commented Apr 19, 2022

I keep changing my mind on this. On the one hand, the name suggests that this is a good idea. On the other, VFE / DTC / FITC don't add any additional deps to AbstractGPs, and the approximate posteriors produced satisfy the AbstractGPs API.

I don't think I would get in the way of this move, but I can also live with the status quo.

@theogf
Copy link
Member Author

theogf commented Apr 19, 2022

Well in my naive user experience, I kept looking in ApproximateGPs for it before realizing it was in AbstractGPs after asking on Slack.

@willtebbutt
Copy link
Member

Haha fair enough. If you didn't know it was there, we should probably just move it here.

@ngiann
Copy link

ngiann commented Jun 19, 2024

Just to add my 2 cents (far more naive than @theogf): After quite some digging to figure out where does Stheno find VFE, I was quite surprised to find it in AbstractGPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants