Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding non_backtracking_matrix function's return type #326

Closed
KeishiS opened this issue Jan 14, 2024 · 1 comment · Fixed by #328
Closed

Question regarding non_backtracking_matrix function's return type #326

KeishiS opened this issue Jan 14, 2024 · 1 comment · Fixed by #328

Comments

@KeishiS
Copy link
Contributor

KeishiS commented Jan 14, 2024

Thank you for your ongoing development efforts.
I have a question concerning the non_backtracking_matrix function. I noticed it returns a non-sparse matrix, whereas the adjacency_matrix function returns a sparse matrix. Can I ask you for some insight into the reasons behind this choice?

If there's no specific reason for using a non-sparse matrix, I'd love to submit a pull request to modify the function so that it returns a sparse matrix.

Thanks for your time!

@gdalle
Copy link
Member

gdalle commented Jan 14, 2024

I don't think there is a reason for it not to be sparse, feel free to submit a PR fixing it! Review may take a while but if the PR is simple enough we shouldn't have any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants