Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify security boundaries #115

Closed
chethega opened this issue Sep 26, 2018 · 2 comments · Fixed by #387
Closed

Clarify security boundaries #115

chethega opened this issue Sep 26, 2018 · 2 comments · Fixed by #387

Comments

@chethega
Copy link

The intended security boundaries are somewhat unclear: Is deserialization of a malicious jld2 file supposed to be equivalent to running a malicious julia script with current user permissions? Or is it supposed to be safe?

Actual security properties are a separate question, this one is rather about the project goals.

If this is not supposed to be a security boundary, then a note in the README.md would be appropriate.

@simonster
Copy link
Member

It...could be safe? Unlike JLD, it doesn't call eval on anything out of the file. But to be safe, it probably needs to be the case that 1) there are no cases where an invalid file can make JLD2 do an out-of-bounds write or similar and 2) there are no types that JLD2 could be made to create that would trigger similar issues in Julia itself. In both cases, if there is such an issue, we should fix it. But I wouldn't claim that reading a JLD2 file is safe without more careful auditing of the code.

@chethega
Copy link
Author

Should examples triggering (2) go on the public issue tracker? Or is there a preferred way to send them privately?

I think that they can go on the public tracker: As you said, currently nobody should rely on safety anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants