Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eachrow, eachcol, eachslice support #639

Closed
oxinabox opened this issue Jan 9, 2019 · 3 comments
Closed

eachrow, eachcol, eachslice support #639

oxinabox opened this issue Jan 9, 2019 · 3 comments

Comments

@oxinabox
Copy link
Contributor

oxinabox commented Jan 9, 2019 •
edited
Loading

For people supporting 1.1 and 1.0,
this is useful.

JuliaLang/julia#29749
@jiegillet
Copy link
Contributor

I'd be happy to do a PR for this, as my package already uses Compat for isnothing, but has an ugly if VERSION < v"1.1" thing in it for eachrow.
I think I can mostly figure out how to get started on the PR, but I don't know how to get the v"1.1.0-DEV.XXX" precise number from the PR listed above.

@jiegillet jiegillet mentioned this issue Jul 24, 2019
Merged
@oxinabox
Copy link
Contributor Author

I don't know how to get the v"1.1.0-DEV.XXX" precise number from the PR listed above.

Don't bother, noone is using -DEV versions of 1.1
having it down to the exact build number is only useful for while that version is at HEAD.

@martinholters
Copy link
Member

Fixed by #658.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oxinabox @martinholters @jiegillet