-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base.lock and Base.unlock not implemented for SSLContext #233
Comments
We do support some locking (see the |
I was trying to use it with ClusterManager as a replacement for Sockets, no such luck as the state of serializer / deserializer is corrupt. Apparently ClusterManager is using |
Ok, that sounds reasonable. I guess I wonder if we can implement what's necessary using the existing lock fields, or if something additional will be required. If you're willing to try things out, I'm happy to help review what ideas you have in a pull request. It might be helpful in your testing, in addition to your own use-case with ClusterManager, to run the HTTP.jl tests on your MbedTLS.jl changes, since it exercises a lot of the ssl.jl codepaths. |
datalock could work but for some reason it is checking for the number of times it was locked - https://github.com/JuliaLang/MbedTLS.jl/blob/master/src/ssl.jl#L594 - if this is removed no big changes are required. |
Yeah, that looks fishy; fine to remove. |
Otherwise concurrent writes and reads corrupt the data, would it be worth implementing? I can take a stab at it.
The text was updated successfully, but these errors were encountered: