From 07df4bb9a262632f7d0e830bcc0e8f67678d692e Mon Sep 17 00:00:00 2001 From: Lilith Orion Hafner Date: Wed, 14 Aug 2024 21:23:43 -0500 Subject: [PATCH] Do not load `ScopedValues` with `using` (#55452) Stop loading `ScopedValues` with `using` so folks use `ScopedValues.with` or `using ScopedValues` rather than `Base.with`. Implements https://github.com/JuliaLang/julia/pull/55095#issuecomment-2272334437 ~Have to bump the StyledStrings stdlib to include https://github.com/JuliaLang/StyledStrings.jl/pull/80~ Done --------- Co-authored-by: Dilum Aluthge (cherry picked from commit e1aefebe1e3c62339be4b46043625170ec538137) --- base/Base.jl | 1 - base/logging/logging.jl | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/base/Base.jl b/base/Base.jl index 438d08e2e01d1..21c9a101758a0 100644 --- a/base/Base.jl +++ b/base/Base.jl @@ -399,7 +399,6 @@ include("weakkeydict.jl") # ScopedValues include("scopedvalues.jl") -using .ScopedValues # metaprogramming include("meta.jl") diff --git a/base/logging/logging.jl b/base/logging/logging.jl index 7124ffe25abf2..c1602abcdbe4a 100644 --- a/base/logging/logging.jl +++ b/base/logging/logging.jl @@ -3,7 +3,7 @@ module CoreLogging import Base: isless, +, -, convert, show -import Base: ScopedValue, with, @with +import Base.ScopedValues: ScopedValue, with, @with export AbstractLogger,