Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow compilation on windows #16987

Closed
SimonDanisch opened this issue Jun 17, 2016 · 5 comments
Closed

Slow compilation on windows #16987

SimonDanisch opened this issue Jun 17, 2016 · 5 comments
Labels
system:windows Affects only Windows

Comments

@SimonDanisch
Copy link
Contributor

On windows, the Julia instances started to precompile don't use precompiled=yes.
As a result, GLVisualize needs almost 10 min to compile.
Starting Julia without precompiled=yes accounts for ~23s per Julia instance, which adds up to a lot when firing up an instance per package.
Can we add precompiled=yes to https://github.com/JuliaLang/julia/blob/master/base/loading.jl#L458 ?
Or at least, propagate the flag? ;)

@pao
Copy link
Member

pao commented Jun 17, 2016

I think #16953 etc. has this covered.

@pao pao closed this as completed Jun 17, 2016
@KristofferC
Copy link
Sponsor Member

KristofferC commented Jun 17, 2016

It is not the same. This is just for the spawned precompilation processes where the problem with bad backtraces should matter much less.

@carnaval
Copy link
Contributor

also if the user opt-in the bad backtraces in the parent process it's probably reasonable to do the same for the child

@carnaval carnaval reopened this Jun 17, 2016
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 17, 2016

It might be safe there. I couldn't really care less about whether you are stuck with bad backtraces, but unfortunately, you're stuck with ntdll, which does care. Backtraces must be perfect to ensure proper signal delivery (aka doesn't cause ntdll to instantly terminate the process), such as gc-statepoints, stack-overflow handling, debugger breakpoints, and perhaps a few other async events (such as GMP Div/0).

@tkelman tkelman added the system:windows Affects only Windows label Jun 17, 2016
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 29, 2016

dup #16953

@vtjnash vtjnash closed this as completed Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

No branches or pull requests

6 participants