file testset fails unless curl is installed (0.6.0)

[ilia-kats]

In particular, the exact failure is

Test Failed
  Expression: download("ba\0d", "good")
    Expected: ArgumentError
      Thrown: Base.UVError

This boils down to download() choosing wget to download the file. Wget is never run however, since run() throws the ArgumentError. The catch clause (interactiveutil.jl:595) assumes that wget did run, and tries to remove the newly created file, which fails with UVError since the file was not greated due to wget never being executed.

[tkelman]

thanks for reporting and debugging a bit. throwing a different exception depending on what downloader is used doesn't seem desirable to me. why does wget curl throw an ArgumentError but curl wget doesn't?

[ilia-kats]

sorry, clicked on the wrong button...
it's the other way around: curl throws ArgumentError, wget doesn't. In both cases, run() throws ArgumentError, but when wget is used that error is caught and the catch clause tries to do some cleanup after wget, where rm() throws the UVError.

[tkelman]

Ah, gotcha. That seems like an oversight in #21071 then, maybe that rm call should use the force keyword argument?

[ilia-kats]

probably, yes

[KristofferC]

I think this should be fixed with the new ´Downloads` stdlib.