Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-array manifold with JuMP/MOI #274

Open
1 task
blegat opened this issue Jun 21, 2023 · 2 comments
Open
1 task

Non-array manifold with JuMP/MOI #274

blegat opened this issue Jun 21, 2023 · 2 comments

Comments

@blegat
Copy link
Contributor

blegat commented Jun 21, 2023

In JuMP, we only define array-shaped points in manifold but as mentioned, e.g., in #264 (comment), for FixedRankMatrices they could also be represented by their SVD.
We should make this work:

@variable(model, X in FixedRankMatrices(m, n, r))
@objective(model, Min, RiemannianFirstOrderFunction(X -> ..., (g, X) -> ...)))

Any good example of m, n, r and riemannian objective and gradient we could use as test for this ?

Requires

@blegat blegat mentioned this issue Jun 21, 2023
11 tasks
@kellertuer
Copy link
Member

A good example to use would be the Matrix Completion as discussed by Vandereycken in https://arxiv.org/pdf/1209.3834.pdf.

It would probably be best to add such an example directly to ManoptExamples https://github.com/JuliaManifolds/ManoptExamples.jl.

I think I understand your first line of code, you ant to allow X to be an SVDMPoint?
I do not yet understand the second line the RiemannianFirstOrderFunction would basically be a ManifoldGradientObjective with slightly different signatures of cost and grad (namely leaving out the manifold - or hardcoding it in the function otherwise)?

@blegat
Copy link
Contributor Author

blegat commented Jun 21, 2023

I think I understand your first line of code, you ant to allow X to be an SVDMPoint?

Yes

I do not yet understand the second line the RiemannianFirstOrderFunction would basically be a ManifoldGradientObjective with slightly different signatures of cost and grad (namely leaving out the manifold - or hardcoding it in the function otherwise)?

Indeed, I think we can even go for #273 (comment)

@kellertuer kellertuer changed the title Non-array manifold Non-array manifold with JuMP/MOI Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants