Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename KSPSolveTranspose! to Base.LinAlg.At_ldiv_B! #70

Closed
stevengj opened this issue May 18, 2016 · 7 comments
Closed

rename KSPSolveTranspose! to Base.LinAlg.At_ldiv_B! #70

stevengj opened this issue May 18, 2016 · 7 comments

Comments

@stevengj
Copy link
Contributor

When I wrote this function, I didn't realize that there was a "standard" name for this method buried in Base.LinAlg
@JaredCrean2
Copy link
Contributor

I was wondering...
https://github.com/JuliaParallel/PETSc.jl/blob/master/src/ksp.jl#L124

Should that name be exported from Base? A_ldiv_B! is.

@stevengj
Copy link
Contributor Author

stevengj commented May 18, 2016 •
edited
Loading

Seems like it, but we can override the LinAlg function regardless.

@JaredCrean2
Copy link
Contributor

I will open an issue

@JaredCrean2
Copy link
Contributor

(btw, sent you an email about indexing and AbstractArrays)

@stevengj
Copy link
Contributor Author

See also JuliaLinearAlgebra/IterativeSolvers.jl#1 (comment)

@stevengj stevengj mentioned this issue Jun 1, 2016
Merged
@stevengj
Copy link
Contributor Author

stevengj commented Jun 1, 2016

See also JuliaLang/julia#16425. (Jared, when you file related issues, be sure to add cross-references so that the github issues point to one another.)

@simonbyrne
Copy link
Member

Done in #99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonbyrne @stevengj @JaredCrean2