Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely less on PyRef #14

Closed
cjdoris opened this issue Mar 27, 2021 · 0 comments
Closed

Rely less on PyRef #14

cjdoris opened this issue Mar 27, 2021 · 0 comments

Comments

@cjdoris
Copy link
Collaborator

cjdoris commented Mar 27, 2021

Originally PyRef was intended to be the single place to safely hold a reference to a Python object, so that other wrapper types (PyObject, PyList, etc.) could each simply have a PyRef field.

It would actually be simpler to just have these types hold a PyPtr and have a generic finalizer that decrefs whatever is in the ptr field (i.e. re-use pyref_finalize!).

@cjdoris cjdoris closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant