Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL avoid checking embedded Python objects #20

Closed
cjdoris opened this issue Apr 14, 2021 · 0 comments
Closed

DSL avoid checking embedded Python objects #20

cjdoris opened this issue Apr 14, 2021 · 0 comments

Comments

@cjdoris
Copy link
Collaborator

cjdoris commented Apr 14, 2021

We embed PyInternedStrings and PyLazyObjects into the AST, but accessing them still does a NULL check and IncRef each time.

Instead, we could keep a list of all the lazy objects used, and a bool indicating whether or not they have all been checked, and check this once at the start of the DSL block. So the first time, all these objects are initialised, and thereafter we can just extract the pointer value directly.

@cjdoris cjdoris closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant