Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonCall.jl 0.9.19 and 0.9.20 seem broken on julia-nightly on GH actions #513

Open
kshyatt-aws opened this issue Jun 24, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@kshyatt-aws
Copy link

Affects: PythonCall

Describe the bug

When running the tests for BraketSimulator.jl, which use PythonCall.jl, on GitHub actions using julia-nightly, I get the following error:

LoadError: UndefVarError: `pyconvert` not defined in `PythonCall`

Even though as far as I can tell, PythonCall.jl does export this function. It's only occuring on GH actions, I can't reproduce it locally with a checkout of Julialang master.

Please include the steps required to reproduce the bug. This should include not just code but all the steps required to reproduce the bug

Your system
Please provide detailed information about your system:

  • Occurs on Windows, Ubuntu, and macOS runners
  • GH actions julia-nightly and PythonCall.jl 0.9.19 and 0.9.20.

Additional context
Add any other context about the problem here.

@kshyatt-aws kshyatt-aws added the bug Something isn't working label Jun 24, 2024
@kshyatt-aws
Copy link
Author

OK, was able to repro finally using https://github.com/nektos/act. Developing PythonCall.jl doesn't seem to help.

@kshyatt-aws
Copy link
Author

Now can repro locally on my laptop with a latest checkout and make of Julia master + a fresh Pkg.instantiate. Looks like some recent Julia commit broke PythonCall.jl?

@kshyatt-aws
Copy link
Author

Some fun with git bisect reveals the offending JuliaLang/julia commit causing this is JuliaLang/julia@71fa11f

@fatteneder
Copy link

Some fun with git bisect reveals the offending JuliaLang/julia commit causing this is JuliaLang/julia@71fa11f

This issue persists when I revert that commit on master.

But I can also confirm that the issue appears on that commit, and vanishes on its parent 4a65772.

@fatteneder
Copy link

Somehow I can no longer reproduce the problem on JuliaLang/julia@71fa11f.
I tried on two machines, but without success.
This is strange.

@fatteneder
Copy link

fatteneder commented Jun 30, 2024

Could you try resetting the caches in BraketSimulator.jl's CI and then rerun CI?

I would be surprised if that fixed it, but atm I don't know what else to do.
I also can't see any apparent connection between that commit and how it interacts with the import mechanism. I'm puzzled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants