Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #471

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Dockerfile #471

merged 7 commits into from
Feb 5, 2024

Conversation

deed02392
Copy link
Contributor

add basic dockerfile that drops into a bash shell with cgt-calc on path from a pipx venv

@vmartinv
Copy link
Collaborator

vmartinv commented Feb 1, 2024

What do you use this for? Could you also add a section in the README with some commands?

@deed02392
Copy link
Contributor Author

@vmartinv this Docker container means you don't have to install LaTeX on your host (which can take a while). I made this Dockerfile with all the necessary dependencies, so that if you want, you could officially link this repo with say hub.docker.com and then people could simply docker pull capital-gains-calculator and not have to worry about separate build instructions etc..

I updated the README.md with instructions on how it works. The gist is you get the tool running in the container and then just share your tax files with it, run the tool and the output PDF gets dropped in the same directory on your host. You could even generate the report with a single command, rather than get an interactive shell in the container first.

Dockerfile Outdated Show resolved Hide resolved
@deed02392 deed02392 marked this pull request as ready for review February 4, 2024 23:45
@KapJI
Copy link
Owner

KapJI commented Feb 5, 2024

Please format README with prettier to pass CI.

@KapJI
Copy link
Owner

KapJI commented Feb 5, 2024

Thanks!

@KapJI KapJI merged commit 5880163 into KapJI:main Feb 5, 2024
3 checks passed
@KapJI KapJI added the feature New feature or request label Feb 5, 2024
@deed02392 deed02392 deleted the docker branch February 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants