-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: move matplotlib into extras dependency #31
Comments
Hi @wwuck, I don't think placing a burden on the vast majority of users/downstream libs to update the installation is a good tradeoff for this very specific scenario. |
I'm afraid I don't see an easy way to opt out of installing a (heavy) dependency, if one wants it to be present by default. setuptools only allows extra requirements, but not less. |
The only other alternative that comes to mind is doing similar to what the It's not directly equivalent, but in essence you would change the original Then you create a new minimal Existing |
Hi @wwuck, Max and I had a chat about a possible solution and we're not keen on splitting the package at this time. However, what do you think about using an environment variable, e.g. |
@wwuck Can you work with the proposed solution? |
Sorry, using an environment variable feels like too much of a giant hacky band-aid to this problem and leaves too many ways to run into problems if the environment variable needs to be defined every time that we install a package that depends on phik across all of our projects (using virtualenv, tox, nox, vscode, docker, CI/CD, etc.). We are happy to continue with building a custom phik package for our local pypi repository if there is no better fix available. |
Ok. We will keep following setuptools, to see if the feature to remove dependencies will get introduced. For now I'll close the issue. |
Hi, would it be possible to move matplotlib into an extras dependency? We are currently building a custom version of phik for our local production usage without the report.py module as matplotlib is a relatively large download on top of the tiny phik library and we don't need matplotlib for our use cases.
If if is too hard to split out, we can still continue with building our local wheels on each phik release.
Thanks for considering this request.
The text was updated successfully, but these errors were encountered: