Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests for uris #451

Open
bghgary opened this issue Sep 19, 2018 · 2 comments
Open

Add some tests for uris #451

bghgary opened this issue Sep 19, 2018 · 2 comments
Labels
help wanted

Comments

@bghgary
Copy link
Collaborator

bghgary commented Sep 19, 2018

See KhronosGroup/glTF#1449

Might consider adding other uri encoding edge cases as well for completeness.
@emackey
Copy link
Member

emackey commented Sep 19, 2018

My suggestion:

  • Test a URI with an encoded %20 space
  • Test a URI with an un-encoded ' ' space
  • Test various other encoded characters that are allowable as filename characters on most filesystems (maybe $ might be a good test?)

No need to test encoded characters that are illegal in popular filesystems.

@kcoley
Copy link
Collaborator

kcoley commented Jan 9, 2019

Some more for images:

  • Test a URI with an embedded base64 texture
  • Test a URI with an embedded base64 buffer

@stevk stevk mentioned this issue Jun 4, 2019
Open
49 tasks
@bghgary bghgary mentioned this issue Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbtron @emackey @kcoley @bghgary