Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KHR_materials_sheen #1197

Closed
emackey opened this issue Sep 4, 2020 · 10 comments
Closed

Add support for KHR_materials_sheen #1197

emackey opened this issue Sep 4, 2020 · 10 comments
Labels
enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material

Comments

@emackey
Copy link
Member

emackey commented Sep 4, 2020

The spec for KHR_materials_sheen is nearing completion, and could use Blender import and export implementations.

@emackey emackey added enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material labels Sep 4, 2020
@shaykh-qasim
Copy link

The spec for KHR_materials_sheen is nearing completion, and could use Blender import and export implementations.

Hi, is the sheen from blender now supported in GLTF import export? I am not related with coding/webgl but I have a project where a velvet shader is to be used in GLTF, I searched and saw ur post from Nov 2019 where u added KHR_materials_sheen extension manually in GLTF using json pretty, but I am still having a problem, I want to use the sheen tint as well and control the roughness of sheen. How can I do all of it directly from blender nodes and no need for manually editing GLTF

@shaykh-qasim
Copy link

Plus, I also want to control the sheen intensity, I may want to overuse it as well as it is currently very weak in brightness and colour.
Also, can you please explain the process to be in a beginner-friendly method.

@emackey
Copy link
Member Author

emackey commented Oct 23, 2020

Hi @shaykh-qasim, the sheen extension for glTF is believed to be stable now, but not yet implemented in Blender. This issue is to track the feature request for implementing it. We do rely on outside contributions, so there's no firm roadmap for when this might become available.

@shaykh-qasim
Copy link

Hi @shaykh-qasim, the sheen extension for glTF is believed to be stable now, but not yet implemented in Blender. This issue is to track the feature request for implementing it. We do rely on outside contributions, so there's no firm roadmap for when this might become available.

Thanks for the update, I have managed to create the shader thanks to you. I have to report one issue, or I don't know whether it is an issue or something else:

When I input the sheenColorFactor values as

"sheenColorFactor": [0.1, 0.4, 1]

It does not correctly transfer the RGB value to Babylon, the value changes to some other parameters, I manually eye-balled and adjusted the value to match with the Babylon one for my velvet model, just wanted to bring this into your notice if this is a bug or something.

@emackey
Copy link
Member Author

emackey commented Oct 23, 2020

All of glTF's color factors are expressed in linear space, not sRGB. You might need a color conversion.

@shaykh-qasim
Copy link

shaykh-qasim commented Oct 24, 2020

All of glTF's color factors are expressed in linear space, not sRGB. You might need a color conversion.

Hi, How do I control the SHEEN INTENSITY from GLTF? I see there is a factor for controlling roughness and colour but I can't control the intensity, how do I do that?
image

Here I have tried to use this factor, which is not working :
image

Thanks,

@emackey
Copy link
Member Author

emackey commented Oct 24, 2020

Hi @shaykh-qasim, this GitHub issue tracker isn't really the right place for tech support, it's reserved for tracking bugs and features in the Blender glTF addon.

That said, the glTF sheen extension doesn't separate out the intensity, it's blended with sheenColor. Darker colors are the same as lighter colors with less intensity. A sheenColor of black (the default) disables the sheen effect completely, as no light is returned from the sheen.

@shaykh-qasim
Copy link

@emackey Sorry for commenting here, I am new to GitHub and don't know where and how to post. Can you link me to a specific forum for GLTF tech support?

That being said, I have a query of using video/gif/image sequence as textures/material in GLTF, do you know or can you link me to a related solution?

Thanks again and sorry for commenting here as I don't know where else to post.

@donmccurdy
Copy link
Contributor

The glTF forums (https://community.khronos.org/c/gltf-general/45) or Slack (https://khr.io/slack) are good options for technical support.

@emackey emackey linked a pull request Mar 3, 2021 that will close this issue
@julienduroure
Copy link
Collaborator

Well, seems I forgot to close this ticket, now that sheen is supported...
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exporter This involves or affects the export process importer This involves or affects the import process Material
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants