Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated vertex shaders do not need to normalize normals #184

Closed
pjcozzi opened this issue Nov 12, 2013 · 1 comment
Closed

Generated vertex shaders do not need to normalize normals #184

pjcozzi opened this issue Nov 12, 2013 · 1 comment
Labels

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Nov 12, 2013

Since a normal will not remain normal during rasterization interpolation, we should not normalize normals in the generated vertex shaders like we currently do, e.g.,

v_normal = normalize(u_normalMatrix * mat3(skinMat)* a_normal);

Instead, we should just normalize in the fragment shader like we already do:

vec3 normal = normalize(v_normal);
@pjcozzi pjcozzi added this to the converter v1.0 milestone Apr 30, 2014
@fabrobinet fabrobinet removed the dev-7 label May 25, 2014
@fabrobinet
Copy link
Contributor

That was already fixed in recent changes, but not for skinned normal. done now. 28a06ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants