Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion crash #192

Closed
erno opened this issue Nov 22, 2013 · 9 comments
Closed

Conversion crash #192

erno opened this issue Nov 22, 2013 · 9 comments
Labels

Comments

@erno
Copy link

erno commented Nov 22, 2013

Hello,

Ran into this crash while experimenting with glTF. I removed stuff
from the XML as long as the crash looked same in GDB.

Test input: https://gist.github.com/erno/7597809

GDB crash info / stack trace: https://gist.github.com/erno/7597839

Removing elements from the p element inside polylist makes the crash go away.

@fabrobinet
Copy link
Contributor

Thanks for the test-case, I'll have a look this week

@fabrobinet
Copy link
Contributor

@erno I had a look but values are totally wrong in this file. I'll keep it as a test for robustness but it is an invalid file.

@erno
Copy link
Author

erno commented Nov 29, 2013

Ok, thanks for looking. The original was from the Blender exporter...

@fabrobinet
Copy link
Contributor

Would be worth reporting to blender - for instance here:

          <float_array id="Kauppurienkatu11-mesh-positions-array" count="11766">1.68085e-5 -2.55108e-5 7.62939e-6 1.68085e-5 </float_array>

There is an obvious mismatch between the exported values count and the actual values...

@erno
Copy link
Author

erno commented Nov 29, 2013

Ah, that is because of my manual minimization, I stripped the xml as long as the crash looked the same in gdb. The original is here but it's large (~32MB uncompressed): http://playsign.tklapp.com:8000/Masterscene.dae.gz

@fabrobinet
Copy link
Contributor

Ok, that's much better, only an empty controllers_library makes it non compliant, but it is easy to work-around.
I'll let you know what I find... thanks !.

@fabrobinet
Copy link
Contributor

on dev-3 (current development branch) I can't repro a crash. I tried with malloc debug enabled too... You can verify on dev-3 branch or when it is merged in master around early next week.

@fabrobinet
Copy link
Contributor

closing now as merged on master - @erno feel free to reopen if needed.

@erno
Copy link
Author

erno commented Dec 3, 2013

Yep, works here too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants