BUGFIXES #34
Merged
BUGFIXES #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing metadata type.
Removed faulty check blocking background styling.
When value is not set ColorPicker component fallbacks to its own default which is #000000 Added a check to apply that default color to button in said case.
…hboard-sprint-12-bugfix
Redjaw
requested changes
Jul 4, 2023
src/modules/documentExecution/dashboard/generalSettings/background/DashboardBackground.vue
Outdated
Show resolved
Hide resolved
Redjaw
reviewed
Jul 4, 2023
| @@ -52,9 +51,12 @@ export default defineComponent({ | |||
| this.dashboard = this.dashboardModelProp | |||
| if (!this.dashboard.configuration?.background) this.dashboard.configuration.background = { sheetsBackgroundColor: '', imageBackgroundUrl: '', imageBackgroundSize: '' } as IBackground | |||
| this.background = this.dashboard.configuration.background as IBackground | |||
|
|
|||
| console.log('this.dashboard.configuration.background', this.dashboard.configuration.background) | |||
There was a problem hiding this comment.
remember to remove those after testing
Redjaw
approved these changes
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KNOWAGE-7976
KNOWAGE-7997
KNOWAGE-7999
More info in individual commits per issue number.