Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering of suspend lambdas #1418

Closed
sellmair opened this issue Sep 1, 2020 · 3 comments · Fixed by #1483
Closed

Rendering of suspend lambdas #1418

sellmair opened this issue Sep 1, 2020 · 3 comments · Fixed by #1483
Assignees
@BarkingBad
Labels
enhancement An issue for a feature or an overall improvement
Milestone
1.4.20.2

Comments

@sellmair
Copy link
Member

sellmair commented Sep 1, 2020

Source code like:
image

Is currently rendered as :
image

But we should prefer rendering it as block: suspend () -> T instead
@sellmair sellmair added enhancement An issue for a feature or an overall improvement high priority labels Sep 1, 2020
@sellmair sellmair added this to the 1.4.20 milestone Sep 1, 2020
@sellmair
Copy link
Member Author

sellmair commented Sep 1, 2020

Similar #1350

@Kordyjan
Copy link
Contributor

Kordyjan commented Sep 1, 2020

It is part of a more general problem: how should we treat function-like types. Right now they are a special case for us in signature provider. Maybe we should handle them in the model as new kind of type bound.

@Kordyjan Kordyjan mentioned this issue Sep 2, 2020
Closed
@Kordyjan
Copy link
Contributor

Kordyjan commented Sep 2, 2020

I think that the fact that we have three issues with the same root cause (this one, #1350 and #1351) strongly suggests that we should fix that problem on the model level.

@BarkingBad BarkingBad self-assigned this Sep 16, 2020
@BarkingBad BarkingBad linked a pull request Sep 17, 2020 that will close this issue
Add better handling of functional types in rendered output #1483
Merged
@kamildoleglo kamildoleglo modified the milestones: Backlog 1.4.20, 1.4.20-2 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BarkingBad BarkingBad

Labels
enhancement An issue for a feature or an overall improvement
Projects
None yet
Milestone
1.4.20.2
Development

Successfully merging a pull request may close this issue.

Add better handling of functional types in rendered output Kotlin/dokka
4 participants
@kamildoleglo @Kordyjan @BarkingBad @sellmair