-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K2] Methods implemented by delegation miss the override
keyword and KDoc
#3384
Comments
We consider K1's behaviour to be correct in this case, so there should be the |
It can be implemented on Dokka's side. public static boolean isOverride(@NotNull CallableMemberDescriptor descriptor) {
return !descriptor.getOverriddenDescriptors().isEmpty();
} |
Currently, in K2 members implemented by delegation have their own pages and have no KDoc. It is blocked by https://youtrack.jetbrains.com/issue/KT-64833/Analysis-API-Members-implemented-by-delegation-have-no-overridden-symbols to implement it like in K1. Also related: #3196 |
override
keywordoverride
keyword and KDoc
This has been unblocked and fixed upstream, just need to check it and write a test. Note: in K2 if a class inherits a function from an interface, clicking on this function in the child should lead to the interface. The PR #3440 can be resurrected, but not necessarily |
With K1 the
JavaNetCookieJar
gotoverride
keyword and kdoc from the interfaceIn K2 both are missed:
Installation
Parent: #3328
The text was updated successfully, but these errors were encountered: