From cc61d54507ed3359f1272d1c65c60739fcbf9c15 Mon Sep 17 00:00:00 2001 From: Cedric Schwyter Date: Sat, 1 Jul 2023 18:24:13 +0200 Subject: [PATCH] chore:remove `.clone()` in config accessor --- .github/workflows/verify-publish.yaml | 16 +++++++++------- src-tauri/lib.rs | 6 +++--- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.github/workflows/verify-publish.yaml b/.github/workflows/verify-publish.yaml index 843db81..badf8cc 100644 --- a/.github/workflows/verify-publish.yaml +++ b/.github/workflows/verify-publish.yaml @@ -32,21 +32,23 @@ jobs: run: | sudo apt-get update sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev libappindicator3-dev librsvg2-dev patchelf + - name: install cargo-fmt + run: rustup component add rustfmt + - name: install cargo-clippy + run: rustup component add clippy + - name: run cargo:fmt + run: cd src-tauri && cargo fmt --all -- --check - name: install frontend dependencies run: yarn install - uses: tauri-apps/tauri-action@v0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Run cargo:test - run: cd src-tauri && cargo test --verbose --all-features - - name: Run cargo:fmt - run: cd src-tauri && cargo fmt --all -- --check - - name: Run cargo:clippy + - name: run cargo:clippy run: cd src-tauri && cargo clippy --all-features -- -D warnings - - name: Setup Tarpaulin + - name: setup Tarpaulin run: cd src-tauri && cargo install cargo-tarpaulin continue-on-error: true - - name: Run cargo:tarpaulin + - name: run cargo:tarpaulin (runs cargo test) run: cd src-tauri && cargo tarpaulin --verbose --all-features --out Xml --output-dir ./coverage - name: Codecov uses: codecov/codecov-action@v3 diff --git a/src-tauri/lib.rs b/src-tauri/lib.rs index a2ff9da..e95d64d 100644 --- a/src-tauri/lib.rs +++ b/src-tauri/lib.rs @@ -14,7 +14,7 @@ const HUE_BRIDGE_SERVICE_NAME: &str = "_hue._tcp.local"; const HUE_BRIDGE_SERVICE_QUERY_INTERVAL_SECONDS: u64 = 3600; const HUE_BRIDGE_API_BASE_URL: &str = "/clip/v2"; -#[derive(Clone, Debug, Parser)] +#[derive(Debug, Parser)] #[command(author, version, about)] pub struct HueHueHueConfig { #[arg(long)] @@ -54,8 +54,8 @@ impl serde::Serialize for HueHueHueError { } impl HueHueHue { - pub fn get_config(&self) -> HueHueHueConfig { - self.config.clone() + pub fn get_config(&self) -> &HueHueHueConfig { + &self.config } fn get_base_url(&self) -> String {