Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more of the musig spec tests #141

Open
LLFourn opened this issue Dec 16, 2022 · 0 comments
Open

Add more of the musig spec tests #141

LLFourn opened this issue Dec 16, 2022 · 0 comments

Comments

@LLFourn
Copy link
Owner

LLFourn commented Dec 16, 2022

A few new musig spec test type have been added. We should test against them.

See: https://github.com/jonasnick/bips/tree/musig2/bip-musig2/vectors

and look how the python code uses the json files. Currently we have:

  key_agg_vectors.json
  sign_verify_vectors.json
  tweak_vectors.json

Some of the ones provided are not applicable since we handle nonce generation in a different way but I think we could test against some of the others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LLFourn