Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of Hatchet Graphs using igraph #20

Closed
ilumsden opened this issue Feb 9, 2022 · 0 comments
Closed

Improve performance of Hatchet Graphs using igraph #20

ilumsden opened this issue Feb 9, 2022 · 0 comments
Labels
area-graphframe Issues and PRs involving Hatchet's core GraphFrame datastructure and associated classes type-feature Requests for new features or PRs which implement new features type-internal-cleanup PR or issues related to the structure of the codebase, directories and refactors type-question Issues which are not directly requesting a bugfix or feature

Comments

@ilumsden
Copy link
Collaborator

ilumsden commented Feb 9, 2022

While looking into C++ graph libraries for a personal project, I discovered the igraph library. It is a extremely versatile graph library that's written in C/C++ and has bindings to C, Python, R, etc.

Given that there have been performance concerns with respect to certain functionality in Hatchet's Graph class, I'm wondering if it would be possible to reimplement the Graph class using the Python version of igraph.

One thing to note, if we were to do this, the reimplementation would involve moving some functionality (e.g., traverse, dag_equal) out of the Node class and into the Graph class. This would technically be a backwards compatibility-breaking change to Hatchet's API.

I'm opening this issue for discussion of the idea.
@ilumsden ilumsden added area-graphframe Issues and PRs involving Hatchet's core GraphFrame datastructure and associated classes type-feature Requests for new features or PRs which implement new features type-question Issues which are not directly requesting a bugfix or feature labels Feb 9, 2022
@ilumsden ilumsden mentioned this issue Feb 9, 2022
Open
@ilumsden ilumsden added the type-internal-cleanup PR or issues related to the structure of the codebase, directories and refactors label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-graphframe Issues and PRs involving Hatchet's core GraphFrame datastructure and associated classes type-feature Requests for new features or PRs which implement new features type-internal-cleanup PR or issues related to the structure of the codebase, directories and refactors type-question Issues which are not directly requesting a bugfix or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilumsden