Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coded values in NNLS solver #269

Open
dreamer2368 opened this issue Feb 13, 2024 · 0 comments
Open

Hard-coded values in NNLS solver #269

dreamer2368 opened this issue Feb 13, 2024 · 0 comments
Labels
enhancement help wanted

Comments

@dreamer2368
Copy link
Collaborator

Line 66 and 163 of lib/linalg/NNLS.cpp use hard-coded values of n_proc_max_for_partial_matrix_ = 15 and nb = 3, which seem to be used mainly for distributing the matrix.

  • There is no sufficient description as to why these values are chosen.
  • For better scalability of this solver, shouldn't these values be determined by the users?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dreamer2368