Why not generating edc data for non data sectors of str?

[marco-calautti]

At the following line, I was expecting a mode2form2 mode:

mkpsxiso/src/iso.cpp

Line 1096 in 7196686

writer->WriteBytesXA( buff, 2336, cd::IsoWriter::EdcEccNone );

Don't know about other str generation tools, but the official one (mc32), leaves edc blank in mode 2 form 2 sectors. So, rebuilding a bin with the current version of mkpsxio will be recognized as a bin with errors (tested this on Megaman Legends).

[Lameguy64]

I don't exactly remember the reason why I chose not to generate EDC for M2F2 format sectors, either it could be because I wanted the output to match MC32's as you described or I forgot to enable it when I got EDC/ECC generation working. It wasn't much of a problem in most cases as the emulators and tools I use don't really check for the EDC/ECC codes and that CD burners typically generate the missing codes while burning.