Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hyper and http dependencies to 1.0 #87

Closed
Nutomic opened this issue Nov 24, 2023 · 5 comments · Fixed by #123
Closed

Upgrade hyper and http dependencies to 1.0 #87

Nutomic opened this issue Nov 24, 2023 · 5 comments · Fixed by #123
Labels
enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented Nov 24, 2023

These result in a lot of breaking changes which arent easy to resolve.

https://github.com/hyperium/hyper/blob/master/CHANGELOG.md#v100-2023-11-15

https://github.com/hyperium/http/blob/master/CHANGELOG.md#100-november-15-2023

@Nutomic Nutomic added the enhancement New feature or request label Nov 24, 2023
@kwaa
Copy link
Contributor

kwaa commented Dec 1, 2023

Since hyper was upgraded to 1.0, maybe axum should be upgraded to 0.7 as well?
https://tokio.rs/blog/2023-11-27-announcing-axum-0-7-0

@j0lol
Copy link

j0lol commented Mar 3, 2024

Depends on actix/actix-web#3208, cant update http until actix does

@j0lol
Copy link

j0lol commented Mar 3, 2024

Also reqwest has not updated to http 1.0: seanmonstar/reqwest#2059

@j0lol
Copy link

j0lol commented Mar 4, 2024

Here's my best attempt at getting it working on hyper/http 1: https://github.com/j0lol/activitypub-federation-rust

I had to remove actix (for now) and tests fail because of reqwest but it seems to work on my project? I have not tested it much though

@kwaa
Copy link
Contributor

kwaa commented Jun 22, 2024

It looks like actix-web won't upgrade http crate until v5, and v5 has no due date...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants