Fix a bug with a disjunctive license #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug-with-disjunctive-license
ivastly
requested review from
martin-georgiev,
ben-challis and
marmichalski
ben-challis
changed the title
ben-challis
reviewed
Sep 20, 2023
ben-challis
reviewed
Sep 20, 2023
marmichalski
approved these changes
Sep 20, 2023
ben-challis
deleted the
ticket/ZEND-2908-fix-bug-with-disjunctive-license
branch
|
Thanks @ivastly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior with a disjunctive license (e.g. "MIT, WTFPL, GPL-3.0-only").
Disjunctive license means that the user can choose any license from the list. Therefore,
composer-license-checkershould allow the package if at least one license is allowed. Before, it was checking all licenses from the list and demanding all of them to be allowed.