Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe a new patch release? #2734

Closed
ioangatop opened this issue Sep 11, 2024 · 8 comments
Closed

Maybe a new patch release? #2734

ioangatop opened this issue Sep 11, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@ioangatop
Copy link

Motivation

A new release will help since there were some refactoring in the segmentation metrics.

Thanks a lot 🙏

@ioangatop ioangatop added the enhancement New feature or request label Sep 11, 2024
@Borda
Copy link
Member

Borda commented Sep 11, 2024

sure I can do one today :)

@SkafteNicki
Copy link
Member

Closing as v1.4.2 was released yesterday :]

@ioangatop
Copy link
Author

hmmm that is kinda weird as the new release for example does not have the following argument from main - how is this not included 🤔 ?

input_format: Literal["one-hot", "index"] = "one-hot",

@ioangatop
Copy link
Author

@Borda do you maybe know why this happen? thank you 🙏

@Borda
Copy link
Member

Borda commented Sep 23, 2024

@Borda do you maybe know why this happen? thank you 🙏

what do you mean?

@ioangatop
Copy link
Author

For example, lets get the GeneralizedDiceScore; on the release it seems that it has an older code from the main at that time. For example:

# on main; 3 weeks ago
class GeneralizedDiceScore(Metric):
    ...
    def __init__(
        self,
        num_classes: int,
        include_background: bool = True,
        per_class: bool = False,
        weight_type: Literal["square", "simple", "linear"] = "square",
        input_format: Literal["one-hot", "index"] = "one-hot",                # <-- HERE
        **kwargs: Any,
    ) -> None:
# on release 1.4.2; 2 weeks ago
class GeneralizedDiceScore(Metric):
    ...
    def __init__(
        self,
        num_classes: int,
        include_background: bool = True,
        per_class: bool = False,
        weight_type: Literal["square", "simple", "linear"] = "square",
                                                                             # <-- HERE missing arg
        **kwargs: Any,
    ) -> None:

@Borda
Copy link
Member

Borda commented Sep 23, 2024

Thanks for your concern. We have released patch release recently which by nature does not expect API changes, correct?

@ioangatop
Copy link
Author

@Borda make sense yeah... I guess I wanted to have a minor release? and is this will be possible? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants