Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add Deploy status badge in README.md #766

Closed
raghunath-r-a opened this issue Sep 27, 2021 · 14 comments · Fixed by #780
Closed

Need to add Deploy status badge in README.md #766

raghunath-r-a opened this issue Sep 27, 2021 · 14 comments · Fixed by #780

Comments

@raghunath-r-a
Copy link
Collaborator

raghunath-r-a commented Sep 27, 2021

Please add the Deploy status badge in README.md

Status badges are visual representations of a site's status, served as image files that can be added to the site repository's READMEs, documentation, or any other web page. Please follow this URL

@Pradumn-18
Copy link

I suppose there are some inconsistency with the deployment command. Because the npm i command throws error.

@abhir9
Copy link
Contributor

abhir9 commented Sep 28, 2021

@Pradumn-18 could you share a screenshot.

@Pradumn-18
Copy link

Yeah sure, I am attaching the log file of Netlify deployment build for better insights. The package installation is fine now. I figured that the package installation works fine with lower NodeJs version like 14.x, 12.x but gives error on 16.x. Now I face error in "npm run develop" command mentioned in README.md of the repository.

Please take a deep look into it.

Log_File.txt

@AmreshSinha
Copy link

AmreshSinha commented Sep 30, 2021

Tried on Travis-CI
Build is succeeding on Node v14.18.0 but failing on v16.10.0

This is the failing one:
https://api.travis-ci.com/v3/job/540618696/log.txt

@AmreshSinha
Copy link

@raghunath-r-a @abhir9 you can assign me this issue. Just specify the final testing platform. I prefer going with Travis or as @Pradumn-18 said Netflify.

@Pradumn-18
Copy link

@AmreshSinha I guess Travis CI will not be preferable because their you would not be able to deploy the site. It will start executing the build but at last this is basically a site to be hosted, which will keep running in your build if it passes.I myself tried same on Github Action which is equivalent to Travis CI.

Moreover could you please share the logs of build that you claim is passing.

@AmreshSinha
Copy link

AmreshSinha commented Sep 30, 2021

@AmreshSinha I guess Travis CI will not be preferable because their you would not be able to deploy the site. It will start executing the build but at last this is basically a site to be hosted, which will keep running in your build if it passes.I myself tried same on Github Action which is equivalent to Travis CI.

Moreover could you please share the logs of build that you claim is passing.

@Pradumn-18
Yeah it will be purely used for testing purposes and not for actual production build purpose.

and the fail error log:
https://api.travis-ci.com/v3/job/540618696/log.txt

Ig the thing is with node version. It's working fine in node v14.x or node v12.x (as in Travis-CI)

@Pradumn-18
Copy link

@AmreshSinha Yes I agree to that, it fails with node version 16.x as I have also pointed out same in my prior comment.

@abhir9 abhir9 linked a pull request Oct 1, 2021 that will close this issue
3 tasks
@pareek-naren pareek-naren linked a pull request Oct 1, 2021 that will close this issue
3 tasks
@raghunath-r-a
Copy link
Collaborator Author

raghunath-r-a commented Oct 1, 2021

@AmreshSinha @Pradumn-18 Thanks for highlighting this issue. This issue is due to an older version of Gatsby being used. We've created a new issue for the same: #789

Meanwhile, adding a status badge in README.md has been addressed by another pull request. (For your reference: #780)

CC: @abhir9 @mohammed786 @pareek-narendra

@mohammed786
Copy link
Collaborator

@Pradumn-18 Seems like gatsby version used in this portal is 2.x.x, which is not supported in node v16.x, kindly raise the PR in support to node version either v14.x or v12.x to run it locally till we upgrade the gatsby version for this portal.

For more details checkout this issue #789

@Pradumn-18
Copy link

Though the PR seems to have merged but unfortunately I am still not able to the badge for Netlify deployment.

Could you please look into that.

@Pradumn-18
Copy link

@mohammed786 Sure would do that.

@donjosemathew
Copy link

Wish to work on that

@raghunath-r-a
Copy link
Collaborator Author

@dontech09 Thanks for your interest in fixing this. But this has been already addressed by this pull request: #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants