Time to soc #94
Merged
Time to soc #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User configurable options: -TimeToSoC points -TimeToSoC update frequency (loop cycles) -TimeToSoC display of negative time when moving away from SoC points -TimeToSoC display format of seconds or time string or both -Battery Cell data format
Removed import of timedelta
Louisvdw
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
battery.py
-Add variable time_to_soc_update to support updating TimeToSoC values every TIME_TO_SOC_LOOP_CYCLES
-Modified function get_timetosoc to receive pre-calculated crntPrctPerSec and produce user configured TimeToSoC format via TIME_TO_SOC_VALUE_TYPE and results of negative SoC times (when moving away from an SoC point) via user configured TIME_TO_SOC_INC_FROM
daly.py
-Change poll_interval from 2000 to 1000 to allow more frequent calls to refresh_data given smaller data set collection with the introduction of poll_step method
-Add variable poll_step to hold step number between calls to refresh_data
-Add support for refreshing only specific data sets during each refresh_data cycle
-Disabled logger call while reading cell voltages
dbushelper.py
-Add support for user configured battery cell data format via BATTERY_CELL_DATA_FORMAT
-Add support for user configured TimeToSoC points via TIME_TO_SOC_POINTS instead of fixed points
-Add support for updating TimeToSoC point values only every TIME_TO_SOC_LOOP_CYCLES instead of all publish_dbus cycles
utils.py
-Add user config variables to control TimeToSoC functions and battery cell data formats, along with info/examples of the purpose for the variables