Single serial port object #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User configurable options: -TimeToSoC points -TimeToSoC update frequency (loop cycles) -TimeToSoC display of negative time when moving away from SoC points -TimeToSoC display format of seconds or time string or both -Battery Cell data format
Removed import of timedelta
Implement single serial port object for all reads during refresh_data instead of multiple open/close for each data set read. This results in a notably faster refresh_data processing and reduced read errors. Currently implemented for daly only as I do not have other BMS available for testing. It was noted during testing that reading too many data sets in each cycle (by combining data set reads into less poll steps), of those found in the poll_step logic, would cause invalid data returned (but have not yet isolated which data sets have this issue). So at this time they remain as separate reads.
Louisvdw
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement single serial port object for all reads during refresh_data instead of multiple open/close for each data set read.
This results in a notably faster refresh_data processing and reduced read errors.
Currently implemented for daly only as I do not have other BMS available for testing.
It was noted during testing that reading too many data sets in each cycle (by combining data set reads into less poll steps), of those found in the poll_step logic, would cause invalid data returned (but have not yet isolated which data sets have this issue). So at this time they remain as separate reads.