Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Block Disruption Not Marked #1805

Closed
chadvandy opened this issue Jan 3, 2023 · 1 comment
Closed

Comment Block Disruption Not Marked #1805

chadvandy opened this issue Jan 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@chadvandy
Copy link

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Diagnostics/Syntax Checking

Expected Behaviour

The debugger should mark the nested comment block as erroneous, because Lua will still interpret the contents within a comment block for other comment triggers including the close block.

Actual Behaviour

The debugger doesn't mark the comment block as erroneous, instead allowing it to seem fine to have two comment blocks within another.

Reproduction steps

  1. Put a regular full comment block, ie. "--[[" and "--]]" around any block of code.
  2. Put another "--[[" before the closing "--]]".
  3. Try to run that code; should spit out a compilation error.

image

Additional Notes

No response

Log File

No response

@sumneko sumneko added the bug Something isn't working label Jan 6, 2023
@sumneko
Copy link
Collaborator

sumneko commented Jan 6, 2023

Only affect Lua 5.1 (exclude LuaJIT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants