Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0 #3159

Closed
9 tasks done
IAlibay opened this issue Mar 14, 2021 · 7 comments
Closed
9 tasks done

Release 1.1.0 #3159

IAlibay opened this issue Mar 14, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@IAlibay
Copy link
Member

IAlibay commented Mar 14, 2021

Hi all,

Having recently completed 1.0.1, we would like to quickly deliver 1.1.0 ASAP.

This is because:

  1. Windows does not currently work with 1.0.1
  2. There are lots of very useful features sitting in 2.0 which cannot be used (RDKIT, MSD, new helanal, etc...)
  3. Maintaining the 1.x branch is becoming unmanageable - we are now at a point where even py3.6 is getting dropped by upstream packages.

In order to speed things up, we would like to propose a 1 week deadline for code fixes. That is to say, unless there is a good reason not to, after the 21st of March 2021, we will put a code freeze on the current master branch and move towards making a release.

After discussions with @richardjgowers and @lilyminium, it is our view that anything that requires longer than that should probably just go into 2.0. Please do speak up if you disagree with this.

As it stands, this is the list of things I believe were earmarked for a final 1.x release:

Is there anything else we need to do? Is this reasonable for everyone?

pinging @MDAnalysis/coredevs

@IAlibay IAlibay added this to the 1.1.0 milestone Mar 14, 2021
@lilyminium
Copy link
Member

re: temp/bfactors -- we could warn for the extremely rare case that someone has used add_TopologyAttr so that both factors are in the same universe, but contain different values, possibly as tags. I'll see if I can make a warning for that case only (that both exist).

@orbeckst
Copy link
Member

orbeckst commented Mar 14, 2021

1.1.0 is then really the final MDA 1.x release (short of errors in the package build which might require a patch release).

We'll then stop any support for Python 2.7 & 3.6 (yikes... I am unhappy about how fragile the Python ecosystem is... but that's a different rant) and no more bug fixes for 1.x.

(EDIT: The above just restates what https://www.mdanalysis.org/2019/11/06/roadmap/ said: development on 1.x will cease with the release of 2.0)

We should publish a requirement file with last known good versions of all deps that make 1.1.0 work.

@IAlibay
Copy link
Member Author

IAlibay commented Mar 21, 2021

With no surprise to anyone, looks like we'll lapse our deadline, but most PRs (except from any NSGrid changes) are open. So unless there's any objections, let's just say it's a code freeze on any new non-critical PRs. If @MDAnalysis/coredevs can concentrate on reviewing what's open we can move with a release as soon as possible.

@IAlibay
Copy link
Member Author

IAlibay commented Mar 21, 2021

Ah seem to have forgotten about hbond_autocorrel. @richardjgowers how do you want to deal with it?

@tylerjereddy
Copy link
Member

I am unhappy about how fragile the Python ecosystem is

Yeah, the release cadence is 1 major Python version per year now I think.

We should publish a requirement file with last known good versions of all deps that make 1.1.0 work.

We're working on doing something similar upstream--pinning build- and run-time deps in releases for long-term repeatable builds. For example: scipy/scipy#12862

@IAlibay
Copy link
Member Author

IAlibay commented Apr 4, 2021

What's left to do here?

@richardjgowers - is there anything that needs to be done for NSGrid & hbond autocorrel?

@IAlibay
Copy link
Member Author

IAlibay commented May 2, 2021

Release 1.1.1 is now available (we had to skip over 1.1.0 due to a pypi upload issue) 🎉

@IAlibay IAlibay closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants