Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProtoReader based classes don't use kwargs on copy #3664

Closed
IAlibay opened this issue May 13, 2022 · 1 comment · Fixed by #3685
Closed

ProtoReader based classes don't use kwargs on copy #3664

IAlibay opened this issue May 13, 2022 · 1 comment · Fixed by #3685
Labels
API Component-Readers defect
Milestone
2.2.0

Comments

@IAlibay
Copy link
Member

IAlibay commented May 13, 2022

Follow-up from #3642

The copy method of ProtoReader derived classes doesn't account for kwargs which were passed on class construction. The use of convert_units was fixed in #3642 but we should do it for kwargs too.
@IAlibay IAlibay added this to the 2.2.0 milestone May 13, 2022
@IAlibay
Copy link
Member Author

IAlibay commented May 13, 2022

I'm going to put this on the 2.2.0 milestone with the idea that this shouldn't be too much work hopefully (although the fix I have in mind is rather ugly)

@IAlibay IAlibay mentioned this issue May 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Component-Readers defect
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Fix reader copying by storing init arguments MDAnalysis/mdanalysis
2 participants
@orbeckst @IAlibay