Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss, dont close] Precision of distopia functions may vary with architecture #3915

Open
hmacdope opened this issue Nov 10, 2022 · 1 comment
Labels
CZI-performance performance track of CZIEOSS4 grant

Comments

@hmacdope
Copy link
Member

Discussion point for #3914.

Due to the use of VCL based metaprogramming and the way CPU dispatching is done in distopia, some ** very high precision** tests may return different results based on the CPU you have.

For example the analysis/test_distances.py::TestDist::test_pairwise_dist_offset_effect test fails on my ancient local machine but is fine on CI in #3914 with a relative difference of 10^-7 (insignificant IMO).

This shouldn't be an issue as distopia is an optional dependency but I thought I would draw this to people's attention.

@hmacdope hmacdope added the CZI-performance performance track of CZIEOSS4 grant label Nov 10, 2022
@hmacdope
Copy link
Member Author

See #3914, addition of distopia did not require accuracy thresholds to be changed on any tests on any of the CI runners, so doesn't look like much of an issue (at least for now).

@hmacdope hmacdope changed the title [Discuss] Precision of distopia functions may vary with architecture [Discuss, dont close] Precision of distopia functions may vary with architecture Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CZI-performance performance track of CZIEOSS4 grant
Projects
Status: In Progress
Development

No branches or pull requests

1 participant