Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace py-causal by causal-learn? #23

Open
dg46 opened this issue Nov 12, 2021 · 2 comments
Open

Replace py-causal by causal-learn? #23

dg46 opened this issue Nov 12, 2021 · 2 comments
Assignees

Comments

@dg46
Copy link
Collaborator

dg46 commented Nov 12, 2021

Causal-learn "is a python package for causal discovery that implements both classical and state-of-the-art causal discovery algorithms, which is a Python translation and extension of Tetrad."

If it provides the same functionality as the (Java wrapper) py-causal library, but with the algorithms actually implemented in Python, this would free cause2e of any Java dependencies. I need to check out the package in more detail to see if it is that easy.

@dg46 dg46 self-assigned this Nov 12, 2021
@dg46
Copy link
Collaborator Author

dg46 commented Nov 19, 2021

Necessary steps should be:

  • write a new searcher class (analogous to TetradSearcher) that runs the search and communicates the resulting graph to the StructureLearner
  • change the default behaviour of run_search and run_quick_search
  • make dependency on py-causal optional (if users have py-causal installed, they should still be able to use it in cause2e)
  • include dependency on causal-learn in setup and requirements
  • update documentation method for search options
  • update notebooks

@dg46
Copy link
Collaborator Author

dg46 commented Nov 19, 2021

Graph translation after search seems easy, but currently I see no possibilty of passing domain knowledge to the search methods from causal-learn. Created an issue: py-why/causal-learn#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant