Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvement for position variable #6

Open
MMoMM-org opened this issue Nov 16, 2022 · 0 comments
Open

Code Improvement for position variable #6

MMoMM-org opened this issue Nov 16, 2022 · 0 comments
Assignees
Labels
ToDo Things which are not bugs but needs to be fixed

Comments

@MMoMM-org
Copy link
Owner

Style nitpick: for your position variable, you might want to use an object { line: 0, ch: 0 } instead of an array [line, ch]. It will make it easier for you to infer the type and easier to read when you come back to the file without looking at it for a few weeks. You can use the EditorPosition interface if you want.

from: obsidianmd/obsidian-releases#1276

might again come with #2

@MMoMM-org MMoMM-org added the ToDo Things which are not bugs but needs to be fixed label Nov 16, 2022
@MMoMM-org MMoMM-org self-assigned this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ToDo Things which are not bugs but needs to be fixed
Projects
None yet
Development

No branches or pull requests

1 participant