Change version for nightly on anaconda to HEAD #106
Conversation
steppi
changed the title
tools/upload_to_anaconda_posix.sh
Outdated
| @@ -7,4 +7,5 @@ echo $(python -c "import sys; print(sys.version)") | |||
| sudo chmod -R a+w /home/travis/.cache | |||
| pip install -q git+https://github.com/Anaconda-Platform/anaconda-client@1.8.0 | |||
| upload_to_anaconda | |||
| upload_nightlies_to_anaconda | |||
There was a problem hiding this comment.
This will run both functions. I think it would be better to use the $NIGHTLY environment variable like you did above. Does it exist in the environment at this point?
There was a problem hiding this comment.
ahh, this is used by the travis build (aarch64, s390x, ppc64le) which has not yet been converted to use NIGHTLY and HEAD, so it is not needed yet.
There was a problem hiding this comment.
This will run both functions. I think it would be better to use the
$NIGHTLYenvironment variable like you did above. Does it exist in the environment at this point?
Right, for the travis build, I don't think $NIGHTLY existed at this point. upload_to_anaconda just finds files to upload by matching the pattern libs/openblas*.tar.gz. Running both functions as I implemented them would have lead to the same basic behavior, except that nightlies would have had HEAD in the right part of their urls instead of the version.
ahh, this is used by the travis build (aarch64, s390x, ppc64le) which has not yet been converted to use
NIGHTLYandHEAD, so it is not needed yet.
OK, I'll just get rid of these new steps in the travis build.
|
I think this is only relevant after merge, so I will merge it before CI finishes. Thanks @steppi |
This PR resolves an issue that caused the path to nightly openblas-libs builds to contain the openblas version number instead of HEAD. Currently paths look like
instead of
@mattip identified that the issue is in the line
-v "$(cd OpenBLAS && git describe --tags --abbrev=8)"that is in bothmultibuild.ymland `build_steps.sh``.I've fixed both files.
multibuild.ymlwas straightforward to fix because the script to upload to anaconda is aware of whetherNIGHTLYis true. Formultibuild.ymlthe function to upload to anaconda currently just searches for files matching the patternopenblas*.tar.gz. I've separated this into two function, one which matchesopenblas*HEAD*.tar.gz, and the other which matches all strings of the formopenblas*.tar.gzwhich do not contain"HEAD".