Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contourf should support standard colormap attributes #4374

Open
asinghvi17 opened this issue Sep 17, 2024 · 0 comments
Open

contourf should support standard colormap attributes #4374

asinghvi17 opened this issue Sep 17, 2024 · 0 comments
Labels
enhancement Feature requests and enhancements Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume

Comments

@asinghvi17
Copy link
Member

asinghvi17 commented Sep 17, 2024

Currently, contourf only supports colormap and colorscale, but computes colorrange internally, i.e., the user cannot set it without jumping through hoops:

c.attributes[:_computed_levels] = lift(c, zs, c.levels, c.mode) do zs, levels, mode
_get_isoband_levels(Val(mode), levels, vec(zs))
end
colorrange = lift(c, c._computed_levels) do levels
minimum(levels), maximum(levels)
end

and there's no support for explicit highclip or lowclip colors.

Should we compute the levels and colorrange in calculated_attributes!(p::Contourf), and only create polygons in the recipe? Then we can expose the colorrange attribute as well.

cf. https://julialang.slack.com/archives/C8RQUU2KH/p1726592043000659

@asinghvi17 asinghvi17 added enhancement Feature requests and enhancements Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and enhancements Makie Backend independent issues (Makie core) (tri)contour(f) not 3D contour, that's volume
Projects
None yet
Development

No branches or pull requests

1 participant